[cssom-1] Append only one newline in @media rule block#13386
Open
[cssom-1] Append only one newline in @media rule block#13386
Conversation
Member
|
While you're right this needs fixing, this particular fix breaks serilaization of non-empty rules, as it will put the What needs to happen instead is the final newline should be moved into the step that serializes the contents and made dependent on that. |
Collaborator
Author
|
Thanks for catching this mistake. I also applied an obvious bugfix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current algorithm definition requires adding two newlines:
Based on WPT tests and the original commit of the current version, I think this is an obvious bugfix.